Fix missing regenerator runtime dependency in core #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2245 +/- ##
==========================================
+ Coverage 62.94% 62.96% +0.02%
==========================================
Files 485 485
Lines 22716 22716
Branches 5159 5159
==========================================
+ Hits 14298 14303 +5
+ Misses 8148 8143 -5
Partials 270 270
Continue to review full report at Codecov.
|
garrettjstevens
changed the title
|
this change may be good for now, but what if we moved away from using babel/plugin-transform-runtime? we are not targetting older browsers, and may have reduced bundle sizes as a result. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the babel docs, if you use
@babel/plugin-transform-runtime, you need to have@babel/runtimeas a dependency for the package. This adds that missing dependency to our@jbrowse/corepackage. It also makes the "regenerator" option for that plugin betrue, the default, because I was still seeing errors while troubleshooting #2244 unless I made that change.